AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drive-by logging modernization.

Browse Source 
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5970 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Ray Greenwell
2009-09-24 20:18:14 +00:00
parent dae0f7f44f
commit 1c538ac78e
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/as/com/threerings/presents/client/Communicator.as
+7 -9
View File
@@ -165,7 +165,7 @@ public class Communicator
try { try {
_socket.close(); _socket.close();
} catch (err :Error) { } catch (err :Error) {
log.warning("Error closing failed socket [error=" + err + "]."); log.warning("Error closing failed socket", err);
} }
} }
removeListeners(); removeListeners();
@@ -227,7 +227,7 @@ public class Communicator
protected function sendMessage (msg :UpstreamMessage) :void protected function sendMessage (msg :UpstreamMessage) :void
{ {
if (_outStream == null) { if (_outStream == null) {
log.warning("No socket, dropping msg [msg=" + msg + "]."); log.warning("No socket, dropping msg", "msg", msg);
return; return;
} }
@@ -263,14 +263,13 @@ public class Communicator
try { try {
msg = (_inStream.readObject(DownstreamMessage) as DownstreamMessage); msg = (_inStream.readObject(DownstreamMessage) as DownstreamMessage);
} catch (e :Error) { } catch (e :Error) {
log.warning("Error processing downstream message: " + e); log.warning("Error processing downstream message", e);
log.logStackTrace(e);
return; return;
} }
if (frameData.bytesAvailable > 0) { if (frameData.bytesAvailable > 0) {
log.warning("Beans! We didn't fully read a frame, is there a bug in some streaming " + log.warning("Beans! We didn't fully read a frame, is there a bug in streaming code?",
"code? [bytesLeftOver=" + frameData.bytesAvailable + ", msg=" + msg + "]."); "bytesLeftOver", frameData.bytesAvailable, "msg", msg);
} }
if (_omgr != null) { if (_omgr != null) {
@@ -336,8 +335,7 @@ public class Communicator
} }
// total failure // total failure
log.warning("Socket error: " + event, "target", event.target); log.warning("Socket error", "event", event, "target", event.target, new Error());
Log.dumpStack();
shutdown(new Error(AuthCodes.NETWORK_ERROR)); shutdown(new Error(AuthCodes.NETWORK_ERROR));
} }
@@ -346,7 +344,7 @@ public class Communicator
*/ */
protected function socketClosed (event :Event) :void protected function socketClosed (event :Event) :void
{ {
log.info("Socket was closed: " + event); log.info("Socket was closed", "event", event);
_client.notifyObservers(ClientEvent.CLIENT_CONNECTION_FAILED); _client.notifyObservers(ClientEvent.CLIENT_CONNECTION_FAILED);
// if we hadn't loaded our client object yet, behave as if this was a logon failure because // if we hadn't loaded our client object yet, behave as if this was a logon failure because
// we failed before we dispatched a DID_LOGON // we failed before we dispatched a DID_LOGON