Removed the pointless InvocationCodes.SUCCESS, moved it to ChatCodes,

which was the only child class that used it.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@4328 542714f4-19e9-0310-aa3c-eee0fc999fb1

src/as/com/threerings/crowd/chat/data/ChatCodes.as

@@ -33,9 +33,9 @@ import com.threerings.crowd.chat.client.SpeakService;
  */
 public class ChatCodes extends InvocationCodes
 {
-    // TODO: Fucking hell, this sucks balls. It'd be nice if we didn't
+    /** A return value used by the ChatDirector and possibly other entities
-    // have to do this, I tried making SUCCESS prototype const in InvCodes....
+     * to indicate successful processing of chat. */
-    public static const SUCCESS :String = InvocationCodes.SUCCESS;
+    public static const SUCCESS :String = "success";
 
     /** The message identifier for a chat notification message. */
     public static const CHAT_NOTIFICATION :String = "chat";

src/as/com/threerings/presents/data/InvocationCodes.as

@@ -30,12 +30,6 @@ package com.threerings.presents.data {
  */
 public class InvocationCodes
 {
-    /**
-     * Generally used in responses that can either have the value success,
-     * or a string code explaining the reason for failure.
-     */
-    public static const SUCCESS :String = "success";
-
     /** An error code returned to clients when a service cannot be
      * performed because of some internal server error that we couldn't
      * explain in any meaningful way (things like null pointer

src/java/com/threerings/crowd/chat/data/ChatCodes.java

@@ -33,6 +33,10 @@ import com.threerings.crowd.chat.client.SpeakService;
  */
 public interface ChatCodes extends InvocationCodes
 {
+    /** A return value used by the ChatDirector and possibly other entities
+     * to indicate successful processing of chat. */
+    public static final String SUCCESS = "success";
+
     /** The message identifier for a chat notification message. */
     public static final String CHAT_NOTIFICATION = "chat";
 

src/java/com/threerings/presents/data/InvocationCodes.java

@@ -30,12 +30,6 @@ package com.threerings.presents.data;
  */
 public interface InvocationCodes
 {
-    /**
-     * Generally used in responses that can either have the value success,
-     * or a string code explaining the reason for failure.
-     */
-    public static final String SUCCESS = "success";
-
     /** An error code returned to clients when a service cannot be
      * performed because of some internal server error that we couldn't
      * explain in any meaningful way (things like null pointer