AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't fill the array with zeroes when we reinitialize the Throttle with the same number of operations as we already had, as that allows a potentially dangerous burst of operations.

Browse Source 
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5505 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Par Winzell
2008-11-05 17:17:41 +00:00
parent bb670e14a8
commit 1a467468ff
1 changed files with 19 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/as/com/threerings/util/Throttle.as
+19 -18
View File
@@ -68,7 +68,7 @@ public class Throttle
/** /**
* Updates the number of operations for this throttle to a new maximum, retaining the current * Updates the number of operations for this throttle to a new maximum, retaining the current
* history of operations if the limit is being increased and truncating the oldest operations * history of operations if the limit is being increased and truncating the newest operations
* if the limit is decreased. * if the limit is decreased.
* *
* @param operations the new maximum number of operations. * @param operations the new maximum number of operations.
@@ -76,24 +76,25 @@ public class Throttle
*/ */
public function reinit (operations :int, period :int) :void public function reinit (operations :int, period :int) :void
{ {
var ops :Array = ArrayUtil.create(operations, 0);
var ii :int;
var oldestOp :int;
if (operations > _ops.length) {
// copy to a larger buffer, leaving zeroes at the beginning
oldestOp = _oldestOp + operations - _ops.length;
ArrayUtil.copy(_ops, 0, ops, 0, _oldestOp);
ArrayUtil.copy(_ops, _oldestOp, ops, oldestOp, _ops.length - _oldestOp);
} else if (operations < _ops.length) {
// if we're truncating, copy the first (oldest) stamps into ops[0..]
var endCount :int = Math.min(_ops.length - _oldestOp, operations);
ArrayUtil.copy(_ops, _oldestOp, ops, 0, endCount);
ArrayUtil.copy(_ops, 0, ops, endCount, operations - endCount);
_oldestOp = 0;
}
_ops = ops;
_period = period; _period = period;
if (operations != _ops.length) {
var ops :Array = ArrayUtil.create(operations, 0);
if (operations > _ops.length) {
// copy to a larger buffer, leaving zeroes at the beginning
var oldestOp :int = _oldestOp + operations - _ops.length;
ArrayUtil.copy(_ops, 0, ops, 0, _oldestOp);
ArrayUtil.copy(_ops, _oldestOp, ops, oldestOp, _ops.length - _oldestOp);
} else {
// if we're truncating, copy the first (oldest) stamps into ops[0..]
var endCount :int = Math.min(_ops.length - _oldestOp, operations);
ArrayUtil.copy(_ops, _oldestOp, ops, 0, endCount);
ArrayUtil.copy(_ops, 0, ops, endCount, operations - endCount);
_oldestOp = 0;
}
_ops = ops;
}
} }
/** /**