From 00954dff5b15783954addb94924b0b78c7b629ab Mon Sep 17 00:00:00 2001
From: Jamie Doornbos <jamie@threerings.net>
Date: Thu, 22 Jan 2009 06:46:00 +0000
Subject: [PATCH] Stop spamming the log file with these warnings. The code does
 nothing to prevent them and they are happening all over the shop in msoy.

Was going to try and skip the call to ClientObserver.clientSessionDidEnd if it has not yet been started but there is not clear way to determine the state of a session. It is shared between three different maps in ClientManager and PresentsSession and movement between the states is too complicated, at least for tomorrow's release.

[jamie@whirled1 /export/msoy]$ grep "Requested to release unmapped" log/world-server.log.2009-01-20 |wc -l
     830
[jamie@whirled1 /export/msoy]$ grep "Unregistered client" log/world-server.log.2009-01-20 |wc -l
    1971
[jamie@whirled1 /export/msoy]$ grep "Different clients" log/world-server.log.2009-01-20 |wc -l
     362


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5641 542714f4-19e9-0310-aa3c-eee0fc999fb1
---
 .../com/threerings/presents/server/ClientManager.java | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/java/com/threerings/presents/server/ClientManager.java b/src/java/com/threerings/presents/server/ClientManager.java
index be933a5a3..abd7c1044 100644
--- a/src/java/com/threerings/presents/server/ClientManager.java
+++ b/src/java/com/threerings/presents/server/ClientManager.java
@@ -306,7 +306,7 @@ public class ClientManager
     {
         ClientObject clobj = _objmap.get(username);
         if (clobj == null) {
-            log.warning("Requested to release unmapped client object", "username", username,
+            log.info("Requested to release unmapped client object", "username", username,
                         new Exception());
             return;
         }
@@ -480,12 +480,13 @@ public class ClientManager
 
         // sanity check just because we can
         if (rc == null) {
-            log.warning("Unregistered client ended session", "type", type, "who", username,
-                        "session", session, new Exception());
+            log.info("Ending session: unregistered!", "type", type, "session", session);
+
         } else if (rc != session) {
-            log.warning("Different clients with same username!?", "c1", rc, "c2", session);
+            log.info("Ending session: multiple!", "type", type, "s1", rc, "s2", session);
+
         } else {
-            log.info("Ending session", "type", type, "who", username, "session", session);
+            log.info("Ending session", "type", type, "session", session);
         }
 
         // notify the observers that the session is ended