From ad6a08cdd328a7c19a934fccb23f070dd13c6c79 Mon Sep 17 00:00:00 2001 From: Daniel Gredler Date: Thu, 30 Aug 2018 15:52:11 -0400 Subject: [PATCH] Bitmasks seem to be using wrong operator ("anything | 1 != 0" is always true) Note return value check was changed from != to == based on JavaDoc for return value and logic in overridden method in superclass. --- .../java/com/threerings/getdown/launcher/StatusPanel.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/threerings/getdown/launcher/StatusPanel.java b/src/main/java/com/threerings/getdown/launcher/StatusPanel.java index ada90ed..6154a23 100644 --- a/src/main/java/com/threerings/getdown/launcher/StatusPanel.java +++ b/src/main/java/com/threerings/getdown/launcher/StatusPanel.java @@ -79,11 +79,11 @@ public class StatusPanel extends JComponent public boolean imageUpdate (Image img, int infoflags, int x, int y, int width, int height) { boolean updated = false; - if ((infoflags | WIDTH) != 0) { + if ((infoflags & WIDTH) != 0) { _psize.width = width; updated = true; } - if ((infoflags | HEIGHT) != 0) { + if ((infoflags & HEIGHT) != 0) { _psize.height = height; updated = true; } @@ -92,7 +92,7 @@ public class StatusPanel extends JComponent setSize(_psize); getParent().setSize(_psize); } - return (infoflags | ALLBITS) != 0; + return (infoflags & ALLBITS) == 0; } /**