AfflictionNetworks/getdown
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make security check method final.

Browse Source 
Non-final methods that perform security checks may be overridden in ways that bypass security checks.
This commit is contained in:
Daniel Gredler
2018-08-29 14:33:41 -04:00
parent cdde1c773c
commit de1106e690
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/threerings/getdown/launcher/GetdownAppletConfig.java
+1 -3
View File
@@ -15,14 +15,12 @@ import java.net.MalformedURLException;
import java.net.URL; import java.net.URL;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.Map;
import java.util.Properties; import java.util.Properties;
import javax.swing.JApplet; import javax.swing.JApplet;
import com.samskivert.util.RunAnywhere; import com.samskivert.util.RunAnywhere;
import com.samskivert.util.StringUtil; import com.samskivert.util.StringUtil;
import com.threerings.getdown.data.Application;
import com.threerings.getdown.launcher.ImageLoader; import com.threerings.getdown.launcher.ImageLoader;
import com.threerings.getdown.launcher.RotatingBackgrounds; import com.threerings.getdown.launcher.RotatingBackgrounds;
import com.threerings.getdown.util.Config; import com.threerings.getdown.util.Config;
@@ -310,7 +308,7 @@ public class GetdownAppletConfig
/** /**
* This checks whether the user has accepted our signed * This checks whether the user has accepted our signed
*/ */
protected void securityCheck () throws Exception protected final void securityCheck () throws Exception
{ {
// getdown requires full read/write permissions to the system; if we don't have this, then // getdown requires full read/write permissions to the system; if we don't have this, then
// we need to not do anything unsafe, and display a message to the user telling them they // we need to not do anything unsafe, and display a message to the user telling them they