AfflictionNetworks/getdown
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bitmasks seem to be using wrong operator ("anything | 1 != 0" is always true)

Browse Source 
Note return value check was changed from != to == based on JavaDoc for return value and logic in overridden method in superclass.
This commit is contained in:
Daniel Gredler
2018-08-30 15:52:11 -04:00
parent cdde1c773c
commit ad6a08cdd3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/threerings/getdown/launcher/StatusPanel.java
+3 -3
View File
@@ -79,11 +79,11 @@ public class StatusPanel extends JComponent
public boolean imageUpdate (Image img, int infoflags, int x, int y, int width, int height) public boolean imageUpdate (Image img, int infoflags, int x, int y, int width, int height)
{ {
boolean updated = false; boolean updated = false;
if ((infoflags | WIDTH) != 0) { if ((infoflags & WIDTH) != 0) {
_psize.width = width; _psize.width = width;
updated = true; updated = true;
} }
if ((infoflags | HEIGHT) != 0) { if ((infoflags & HEIGHT) != 0) {
_psize.height = height; _psize.height = height;
updated = true; updated = true;
} }
@@ -92,7 +92,7 @@ public class StatusPanel extends JComponent
setSize(_psize); setSize(_psize);
getParent().setSize(_psize); getParent().setSize(_psize);
} }
return (infoflags | ALLBITS) != 0; return (infoflags & ALLBITS) == 0;
} }
/** /**