Make fields final. Remove redundant modifier on final-class

core/src/test/java/com/threerings/getdown/cache/GarbageCollectorTest.java

@@ -77,7 +77,7 @@ public class GarbageCollectorTest
         assertFalse(_lastAccessedFile.exists());
     }
 
-    @Rule public TemporaryFolder _folder = new TemporaryFolder();
+    @Rule public final TemporaryFolder _folder = new TemporaryFolder();
 
     private File _cachedFile;
     private File _lastAccessedFile;

core/src/test/java/com/threerings/getdown/data/ClassPathTest.java

@@ -47,7 +47,7 @@ public class ClassPathTest
         assertEquals(_secondJar, new File(actualUrls[1].toURI()));
     }
 
-    @Rule public TemporaryFolder _folder = new TemporaryFolder();
+    @Rule public final TemporaryFolder _folder = new TemporaryFolder();
 
     private File _firstJar, _secondJar;
     private ClassPath _classPath;

core/src/test/java/com/threerings/getdown/data/EnvConfigTest.java

@@ -15,9 +15,9 @@ import static org.junit.Assert.*;
 
 public class EnvConfigTest {
 
-    static String CWD = System.getProperty("user.dir");
-    static String TESTID = "testid";
-    static String TESTBASE = "https://test.com/test";
+    static final String CWD = System.getProperty("user.dir");
+    static final String TESTID = "testid";
+    static final String TESTBASE = "https://test.com/test";
 
     private void debugNotes (List<EnvConfig.Note> notes) {
         for (EnvConfig.Note note : notes) {
@@ -33,7 +33,7 @@ public class EnvConfigTest {
             }
         }
         if (msg.length() > 0) {
-            fail("Unexpected notes:" + msg.toString());
+            fail("Unexpected notes:" + msg);
         }
     }
     private void checkDir (EnvConfig cfg) {

core/src/test/java/com/threerings/getdown/data/PathBuilderTest.java

@@ -55,5 +55,5 @@ public class PathBuilderTest
 
     protected File _firstJarFile, _secondJarFile;
 
-    @Rule public TemporaryFolder _appdir = new TemporaryFolder();
+    @Rule public final TemporaryFolder _appdir = new TemporaryFolder();
 }

core/src/test/java/com/threerings/getdown/util/ConfigTest.java

@@ -167,5 +167,5 @@ public class ConfigTest
         return _rando.nextBoolean() ? " " : "";
     }
 
-    protected static Random _rando = new Random();
+    protected static final Random _rando = new Random();
 }

core/src/test/java/com/threerings/getdown/util/FileUtilTest.java

@@ -56,5 +56,5 @@ public class FileUtilTest
         assertEquals(3, visitor.fileCount);
     }
 
-    @Rule public TemporaryFolder _folder = new TemporaryFolder();
+    @Rule public final TemporaryFolder _folder = new TemporaryFolder();
 }