AfflictionNetworks/getdown
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Missing environment variable handled incorrectly (mixup between varName and varValue)

Browse Source
This commit is contained in:
Daniel Gredler
2018-08-30 15:34:18 -04:00
parent cdde1c773c
commit 46f6814952
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/threerings/getdown/data/Application.java
+5 -2
View File
@@ -1141,8 +1141,11 @@ public class Application
StringBuffer sb = new StringBuffer(); StringBuffer sb = new StringBuffer();
Matcher matcher = ENV_VAR_PATTERN.matcher(arg); Matcher matcher = ENV_VAR_PATTERN.matcher(arg);
while (matcher.find()) { while (matcher.find()) {
String varName = matcher.group(1), varValue = System.getenv(varName); String varName = matcher.group(1);
if (varName == null) varName = "MISSING:" + varName; String varValue = System.getenv(varName);
if (varValue == null) {
varValue = "MISSING:" + varName;
}
matcher.appendReplacement(sb, varValue); matcher.appendReplacement(sb, varValue);
} }
matcher.appendTail(sb); matcher.appendTail(sb);