Various tidyings.

This commit is contained in:
Michael Bayne
2013-05-24 18:30:57 +00:00
parent 952d01c55b
commit 8a74276caf
4 changed files with 16 additions and 22 deletions
@@ -20,10 +20,12 @@ import com.google.common.base.Function;
import com.google.common.collect.Iterables; import com.google.common.collect.Iterables;
import com.google.common.collect.Lists; import com.google.common.collect.Lists;
import com.google.common.collect.Sets; import com.google.common.collect.Sets;
import static com.google.common.base.Preconditions.checkArgument;
import com.samskivert.jdbc.ConnectionProvider;
import com.samskivert.jdbc.DatabaseLiaison;
import com.samskivert.util.ArrayUtil; import com.samskivert.util.ArrayUtil;
import com.samskivert.depot.clause.FieldOverride;
import com.samskivert.depot.clause.InsertClause; import com.samskivert.depot.clause.InsertClause;
import com.samskivert.depot.clause.Limit; import com.samskivert.depot.clause.Limit;
import com.samskivert.depot.clause.QueryClause; import com.samskivert.depot.clause.QueryClause;
@@ -31,8 +33,7 @@ import com.samskivert.depot.clause.WhereClause;
import com.samskivert.depot.expression.ColumnExp; import com.samskivert.depot.expression.ColumnExp;
import com.samskivert.depot.expression.SQLExpression; import com.samskivert.depot.expression.SQLExpression;
import com.samskivert.depot.util.Sequence; import com.samskivert.depot.util.Sequence;
import com.samskivert.jdbc.ConnectionProvider; import static com.samskivert.depot.Log.log;
import com.samskivert.jdbc.DatabaseLiaison;
import com.samskivert.depot.impl.DepotMarshaller; import com.samskivert.depot.impl.DepotMarshaller;
import com.samskivert.depot.impl.DepotMigrationHistoryRecord; import com.samskivert.depot.impl.DepotMigrationHistoryRecord;
@@ -48,9 +49,6 @@ import com.samskivert.depot.impl.clause.UpdateClause;
import com.samskivert.depot.impl.expression.ValueExp; import com.samskivert.depot.impl.expression.ValueExp;
import com.samskivert.depot.impl.util.SeqImpl; import com.samskivert.depot.impl.util.SeqImpl;
import static com.google.common.base.Preconditions.checkArgument;
import static com.samskivert.depot.Log.log;
/** /**
* Provides a base for classes that provide access to persistent objects. Also defines the * Provides a base for classes that provide access to persistent objects. Also defines the
* mechanism by which all persistent queries and updates are routed through the distributed cache. * mechanism by which all persistent queries and updates are routed through the distributed cache.
@@ -4,9 +4,6 @@
package com.samskivert.depot.impl; package com.samskivert.depot.impl;
import static com.google.common.base.Preconditions.checkArgument;
import static com.samskivert.depot.Log.log;
import java.lang.reflect.Field; import java.lang.reflect.Field;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.sql.Connection; import java.sql.Connection;
@@ -26,6 +23,12 @@ import com.google.common.collect.ListMultimap;
import com.google.common.collect.Lists; import com.google.common.collect.Lists;
import com.google.common.collect.Maps; import com.google.common.collect.Maps;
import com.google.common.collect.Sets; import com.google.common.collect.Sets;
import static com.google.common.base.Preconditions.checkArgument;
import com.samskivert.jdbc.ColumnDefinition;
import com.samskivert.jdbc.DatabaseLiaison;
import com.samskivert.util.StringUtil;
import com.samskivert.util.Tuple;
import com.samskivert.depot.DatabaseException; import com.samskivert.depot.DatabaseException;
import com.samskivert.depot.Key; import com.samskivert.depot.Key;
@@ -47,12 +50,7 @@ import com.samskivert.depot.clause.QueryClause;
import com.samskivert.depot.expression.ColumnExp; import com.samskivert.depot.expression.ColumnExp;
import com.samskivert.depot.expression.SQLExpression; import com.samskivert.depot.expression.SQLExpression;
import com.samskivert.depot.impl.clause.CreateIndexClause; import com.samskivert.depot.impl.clause.CreateIndexClause;
import com.samskivert.util.ArrayUtil; import static com.samskivert.depot.Log.log;
import com.samskivert.util.StringUtil;
import com.samskivert.util.Tuple;
import com.samskivert.jdbc.ColumnDefinition;
import com.samskivert.jdbc.DatabaseLiaison;
/** /**
* Handles the marshalling and unmarshalling of persistent instances to JDBC primitives ({@link * Handles the marshalling and unmarshalling of persistent instances to JDBC primitives ({@link
@@ -197,10 +197,9 @@ public class HSQLBuilder
@Override protected boolean orderSupported (OrderBy.Order order) @Override protected boolean orderSupported (OrderBy.Order order)
{ {
switch (order) { switch (order) {
case ASC: case DESC: case ASC: case DESC: return true;
return true; default: return false;
} }
return false;
} }
} }
@@ -26,7 +26,7 @@ import com.samskivert.depot.impl.expression.DateFun.DateTruncate;
import com.samskivert.depot.impl.expression.DateFun.DatePart.Part; import com.samskivert.depot.impl.expression.DateFun.DatePart.Part;
import com.samskivert.depot.impl.expression.NumericalFun.Trunc; import com.samskivert.depot.impl.expression.NumericalFun.Trunc;
import static com.samskivert.Log.log; import static com.samskivert.depot.Log.log;
public class MySQLBuilder public class MySQLBuilder
extends SQLBuilder extends SQLBuilder
@@ -176,10 +176,9 @@ public class MySQLBuilder
@Override protected boolean orderSupported (OrderBy.Order order) @Override protected boolean orderSupported (OrderBy.Order order)
{ {
switch (order) { switch (order) {
case NULL: case ASC: case DESC: case NULL: case ASC: case DESC: return true;
return true; default: return false;
} }
return false;
} }
} }