AfflictionNetworks/depot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

We need to allow persistent fields to not exist for longer because we may be

Browse Source 
using magical methods to convert to/from composite runtime fields.
This commit is contained in:
Michael Bayne
2009-07-10 00:05:37 +00:00
parent 65f4c8dff4
commit 4b4ff40ee5
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/samskivert/depot/util/RuntimeUtil.java
+15 -9
View File
@@ -162,7 +162,7 @@ public class RuntimeUtil
{ {
// if there's a custom getter method for the field, use that foremost // if there's a custom getter method for the field, use that foremost
try { try {
final Method method = pclass.getMethod(makeMethodName("get", pfield.getName())); final Method method = pclass.getMethod(makeMethodName("get", rfield.getName()));
if (method.getReturnType().equals(rfield.getType())) { if (method.getReturnType().equals(rfield.getType())) {
return new Getter() { return new Getter() {
public Object get (Object object) throws Exception { public Object get (Object object) throws Exception {
@@ -174,6 +174,12 @@ public class RuntimeUtil
// no problem, keep on truckin' // no problem, keep on truckin'
} }
// if we have no persistent field for the runtime field, we're now out of luck
if (pfield == null) {
throw new IllegalArgumentException("Cannot create mapping for " + rfield + ". " +
"No corresponding field exists in " + pclass + ".");
}
// if the fields match exactly, return a getter that just gets the field // if the fields match exactly, return a getter that just gets the field
if (rfield.getType().equals(pfield.getType())) { if (rfield.getType().equals(pfield.getType())) {
return new Getter() { return new Getter() {
@@ -202,7 +208,7 @@ public class RuntimeUtil
// check for a custom setter method for the field (with the correct argument type) // check for a custom setter method for the field (with the correct argument type)
try { try {
final Method method = pclass.getMethod( final Method method = pclass.getMethod(
makeMethodName("set", pfield.getName()), rfield.getType()); makeMethodName("set", rfield.getName()), rfield.getType());
return new Setter() { return new Setter() {
public void set (Object object, Object value) throws Exception { public void set (Object object, Object value) throws Exception {
method.invoke(object, value); method.invoke(object, value);
@@ -212,6 +218,12 @@ public class RuntimeUtil
// no problem, keep on truckin' // no problem, keep on truckin'
} }
// if we have no persistent field for this runtime field, we're now out of luck
if (pfield == null) {
throw new IllegalArgumentException("Cannot create setter for " + rfield + ". " +
"No corresponding field exists in " + pclass + ".");
}
// if the fields match exactly, return a setter that just sets the field // if the fields match exactly, return a setter that just sets the field
if (rfield.getType().equals(pfield.getType())) { if (rfield.getType().equals(pfield.getType())) {
return new Setter() { return new Setter() {
@@ -242,13 +254,7 @@ public class RuntimeUtil
try { try {
pfields[ii] = pclass.getField(rfields[ii].getName()); pfields[ii] = pclass.getField(rfields[ii].getName());
} catch (NoSuchFieldException nsfe) { } catch (NoSuchFieldException nsfe) {
throw new IllegalArgumentException( // we may have a magical method that handles this field, so leave this null
"Cannot create mapping for " + rfields[ii] + ". " +
"No corresponding field exists in " + pclass + ".");
}
if (!pfields[ii].getType().equals(rfields[ii].getType())) {
throw new IllegalArgumentException("Cannot create mapping from " + pfields[ii] +
" to " + rfields[ii] + ".");
} }
} }
return pfields; return pfields;