AfflictionNetworks/depot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

The 50 ms warning triggers every couple of thousand stores for a relatively large cache, usually with times in the 60-70 ms range which is certainly acceptable as long as they're that rare. Let's bump it to 100 ms since we're still on guard for gremlins.

Browse Source
This commit is contained in:
Par Winzell
2009-01-29 16:38:52 +00:00
parent efb2799167
commit 3b65bc9b01
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/samskivert/depot/EHCacheAdapter.java
+6 -7
View File
@@ -22,7 +22,6 @@ package com.samskivert.depot;
import java.io.Serializable; import java.io.Serializable;
import java.util.Collections; import java.util.Collections;
import java.util.HashSet;
import java.util.Map; import java.util.Map;
import java.util.Set; import java.util.Set;
@@ -77,8 +76,8 @@ public class EHCacheAdapter
} }
CachedValue<T> result = lookup(bin.getCache(), cacheId, key); CachedValue<T> result = lookup(bin.getCache(), cacheId, key);
long dT = System.currentTimeMillis() - now; long dT = System.currentTimeMillis() - now;
if (dT > 50) { if (dT > 100) {
log.warning("Aii! A simple ehcache lookup took over 50 ms!", "cacheId", cacheId, log.warning("Aii! A simple ehcache lookup took over 100 ms!", "cacheId", cacheId,
"key", key, "dT", dT, "lookups", _lookups); "key", key, "dT", dT, "lookups", _lookups);
} }
_lookups ++; _lookups ++;
@@ -101,8 +100,8 @@ public class EHCacheAdapter
} }
bin.getCache().put(new Element(new EHCacheKey(cacheId, key), value != null ? value : NULL)); bin.getCache().put(new Element(new EHCacheKey(cacheId, key), value != null ? value : NULL));
long dT = System.currentTimeMillis() - now; long dT = System.currentTimeMillis() - now;
if (dT > 50) { if (dT > 100) {
log.warning("Aii! A simple ehcache store took over 50 ms!", "cacheId", cacheId, log.warning("Aii! A simple ehcache store took over 100 ms!", "cacheId", cacheId,
"key", key, "dT", dT, "stores", _stores); "key", key, "dT", dT, "stores", _stores);
} }
_stores ++; _stores ++;
@@ -117,8 +116,8 @@ public class EHCacheAdapter
bin.getCache().remove(new EHCacheKey(cacheId, key)); bin.getCache().remove(new EHCacheKey(cacheId, key));
} }
long dT = System.currentTimeMillis() - now; long dT = System.currentTimeMillis() - now;
if (dT > 50) { if (dT > 100) {
log.warning("Aii! A simple ehcache remove took over 50 ms!", "cacheId", cacheId, log.warning("Aii! A simple ehcache remove took over 100 ms!", "cacheId", cacheId,
"key", key, "dT", dT, "removes", _removes); "key", key, "dT", dT, "removes", _removes);
} }
_removes ++; _removes ++;